Skeleton-Less icon indicating copy to clipboard operation
Skeleton-Less copied to clipboard

Re-factoring :

Open aelharrak opened this issue 9 years ago • 5 comments

  • Add repository less/skeleton to simplifying the integration of skeleton framework into any projects (existing / new).
  • Update package.json.
  • Add css minification -- >skeleton.min.css with 6ko :)
  • Separation of code into small files (help to use specific file if needed ).
  • Use more Less syntax

aelharrak avatar Jun 27 '16 10:06 aelharrak

Hello Can you confirm please ?

aelharrak avatar Jun 28 '16 15:06 aelharrak

@aelharrak thanks so much for adding these. Let me review.

WhatsNewSaes avatar Jun 28 '16 23:06 WhatsNewSaes

Hello,

Ok i'm waiting for PR ;)

BR, Amine

2016-06-28 23:56 GMT+00:00 Seth Coelen [email protected]:

@aelharrak https://github.com/aelharrak thanks so much for adding these. Let me review. My only concern is keeping the my Skeleton-Sass https://github.com/WhatsNewSaes/Skeleton-Sass repo consistent and up to date with my Skeleton-less and vice versa.

Would you be interested in replicating in the sass repo if these changes are accepted?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WhatsNewSaes/Skeleton-Less/pull/16#issuecomment-229219002, or mute the thread https://github.com/notifications/unsubscribe/ACUywN1Z5OsVUCvTYuNY0Nl7bH_TOUnWks5qQbSZgaJpZM4I-8zB .

Cordialement,

http://about.me/amine.elharrak

[image: EL HARRAK AMINE on about.me]

EL HARRAK AMINE about.me/amine.elharrak - Ingénieur concepteur développeur SQLI - Rabat http://about.me/amine.elharrak +212 (0)665 94 23 73

aelharrak avatar Jun 29 '16 09:06 aelharrak

PR would conflict with PR #15. Although this seems to be a better approach, it does not provide same functionality as in #15 (overwriting default variables) and is incomplete (missing minor version raise).

filecage avatar Aug 11 '16 14:08 filecage

@WhatsNewSaes I don't see why reviewing this or my PR #15 would take about 3 months. If you're no longer interested in maintaining the project, please consider adding another contributor to allow further development.

filecage avatar Sep 15 '16 21:09 filecage