WhatsApp
Resolve: Issue #54
Fix for the issue https://github.com/WhatsApp/proxy/issues/54
ENV PUBLIC_IP=YOUR_SERVER_PUBLIC_IP
Hi @nimeshkasun!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
To set the PUBLIC_IP environment variable, pass
-e PUBLIC_IP=x.x.x.xto thedocker buildcommand. It is important to note that this value should not be committed to the repository, as it may change depending on the host machine's public IP address.
So, the build command should be like below?
sudo docker build whatsapp-proxy/proxy/ -e PUBLIC_IP=x.x.x.x -t whatsapp_proxy:1.0
if yes, please close the PR. Thanks. :)
@nimeshkasun Yes. Try and see if that works even though I know you don't need to pass it.
Hi @matinzd,
it didn't work with docker build command.
Then I tried with docker run like below, and it worked!
sudo docker run -e PUBLIC_IP=x.x.x.x -it -p 80:80 -p 443:443 -p 5222:5222 -p 8080:8080 -p 8443:8443 -p 8222:8222 -p 8199:8199 whatsapp_proxy:1.0
Your suggestion is easy rather than modifying the docker file itself. Thanks again. Closing the issue since you solved my concern.