plotter-tools icon indicating copy to clipboard operation
plotter-tools copied to clipboard

[Bug fix] Change unwrap_or to unwrap_or_else

Open qirh opened this issue 1 year ago • 0 comments

Similar to this PR (https://github.com/rust-lang/rust/pull/55014).

In unwrap_or the fallback value is evaluated before unwrap_or is called. Which means even though a serial_device arg was provided

./target/debug/chunker ~/plot_file.hpgl /dev/tty.usbserial-1410

The program still failed

detected multiple serial devices: [
    "/dev/tty.usbserial",
    "/dev/tty.usbserial-1410",
], please specify only one!

This PR switches the unwrap_or call to unwrap_or_else. Which will only evaluate the fallback block in the else case.

qirh avatar Nov 09 '24 00:11 qirh