weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Analysis issues do not link to content

Open comradekingu opened this issue 7 years ago • 7 comments

This is the e-mail I got about QR Code Generator/Translations " 'Expecting property name enclosed in double quotes: line 2 column 3 (char 4)'

Erroneous file

src/_locales/en/messages.json"

Would expect link to source and respective Weblate section here.

comradekingu avatar Jun 27 '18 14:06 comradekingu

In this case Weblate failed to parse the file, so the content is not in Weblate and it has to be fixed in the VCS directly. Suggestions to improve the mail are of course welcome.

nijel avatar Jun 27 '18 19:06 nijel

@nijel I was thinking the e-mail could link to the file in the VCS. Which in this case is "https://github.com/rugk/offline-qr-code/blob/master/src/_locales/en/messages.json"

It could quote what the offending property name is.

comradekingu avatar Jun 27 '18 20:06 comradekingu

Unfortunately there is no detailed information from the parser, so this is best error message we can provide.

Link to the VCS should be doable if project has set repository web browser, what is unfortunately not the case for most non Gettext projects...

nijel avatar Jun 27 '18 20:06 nijel

Link to the file should be easy to add since 4b2e079b80103364292464b585186943b7172890 does this in the UI.

nijel avatar Jul 14 '22 09:07 nijel

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

github-actions[bot] avatar Jul 14 '22 09:07 github-actions[bot]

After going through the mentioned commit and the code, I found that, here => https://github.com/WeblateOrg/weblate/blob/main/weblate/templates/mail/parse_error.html, we parse the error and send it in the mail.

I made some changes in the template to test but I am not able to reproduce the issue. Can you please point me to the views code or where the mail is using this template? Thanks

ParthS007 avatar Jul 16 '22 14:07 ParthS007

This is triggered in case the file in the repository cannot be parsed.

In the debug mode, you can also render individual change events directly without going through e-mail when browsing history by clicking on the bell icon.

nijel avatar Jul 17 '22 12:07 nijel

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Aug 18 '22 07:08 github-actions[bot]