helm icon indicating copy to clipboard operation
helm copied to clipboard

Ability to use existing secret for config

Open MPV opened this issue 5 years ago • 5 comments

Hi, This looks promising!

I see you already support setting some "secret" environment variables via values.

In my case, I'd like to be able to configure these and additional environment variables, for example:

GITHUB_TOKEN
WEBLATE_AUTH_LDAP_SERVER_URI

I would also like to do this without needing to put them in my values.yaml file.

...for example by adding a secret beforehand and configuring this chart to use my predefined secret instead of creating a new one.

As this chart is using postgres, here's an example of how the postgres chart either creates a secret or uses an existing one: https://github.com/helm/charts/blob/12a061a/stable/postgresql/templates/_helpers.tpl#L210-L232

What do you think, would you be open to supporting something like this?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

MPV avatar May 12 '20 15:05 MPV

Sure, can you create a PR for it?

The existing secret should be simple, for having additional values from the secret, might make sense to add something similar to the extraConfig that would loop over arbitrary values. Maybe an extraSecretConfig?

tarioch avatar May 12 '20 17:05 tarioch

Sorry, it looks like I'll be giving Hosted Weblate a try first. If that doesn't fulfill our needs, I might come back here and help out some more. 😊

MPV avatar May 14 '20 12:05 MPV

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 31 '20 10:05 stale[bot]

Does the extraSecretName in the Helm chart solve this issue?

eestolano avatar Apr 06 '22 20:04 eestolano

externalSecretName seems to not override existing secrets, so there is no possibility to control for exemple the REDIS_PASSWORD if we deploy redis with this chart.

gllb avatar Sep 15 '22 09:09 gllb