docker icon indicating copy to clipboard operation
docker copied to clipboard

Adding WEBLATE_CLIENT_MAX_BODY_SIZE: 100M to override config

Open ilocit opened this issue 5 years ago • 6 comments

Describe the bug

WEBLATE_CLIENT_MAX_BODY_SIZE: 100M Adding this key to docker-compose.override.yml does not seem to change the max allowed file size for uploads on a docker installation.

To Reproduce

Steps to reproduce the behavior:

  1. Add/Change key in docker-compose.override.yml
  2. Restart weblate docker container

Server configuration and status

weblate docker v 4.2.2

ilocit avatar Oct 21 '20 11:10 ilocit

There is no such setting documented in https://docs.weblate.org/en/latest/admin/install/docker.html

This parameter is currently hardcoded:

https://github.com/WeblateOrg/docker/blob/70194574f95ce9a9843161482611758e664ee767/etc/nginx/default.tpl#L4

nijel avatar Oct 21 '20 11:10 nijel

PS: The https-portal container recommeded for SSL termination accepts CLIENT_MAX_BODY_SIZE, see https://github.com/SteveLTN/https-portal#configure-nginx-through-environment-variables

nijel avatar Oct 21 '20 11:10 nijel

OK. So it means that the https-portal "blocks" the larger files and I need to find and change the settings there. Thanks!

ilocit avatar Oct 21 '20 11:10 ilocit

The setting is used in example docker-compose file:

https://github.com/WeblateOrg/docker-compose/blob/ffcfb3a0549a428c4339ef4a58ef57c6305e2f9e/docker-compose-https.yml#L38

nijel avatar Oct 21 '20 11:10 nijel

Done. Works now. Thanks for this!

ilocit avatar Oct 21 '20 11:10 ilocit

I just wanted to leave a note here that we are easily hitting this hardcoded 100M limit now when uploading project backup archives from another instance. (I'm rebuilding the docker container for another reason anyway, so this isn't a problem right now, but it would be nice if this was configurable from an env var)

Bubu avatar Oct 14 '22 22:10 Bubu

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Mar 15 '23 14:03 github-actions[bot]