linkedom icon indicating copy to clipboard operation
linkedom copied to clipboard

`HTMLAnchorElement` is missing `pathname`

Open damienwebdev opened this issue 3 years ago • 5 comments

https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement/pathname

damienwebdev avatar Aug 01 '22 13:08 damienwebdev

Read through: https://github.com/WebReflection/linkedom/issues/103 I assume this is out of scope.

damienwebdev avatar Aug 01 '22 13:08 damienwebdev

@damienwebdev not sure what has that thread to do with your request ... that thread is about evaluating JavaScript and provide global APIs in here ... your request is about a link attribute?

WebReflection avatar Aug 01 '22 16:08 WebReflection

P.S. the file would be different, it'd be the HTMLAnchorElement instead, but the concept is the same: https://github.com/WebReflection/linkedom/issues/143#issuecomment-1159541964

These kind of requests keep landing without issues as long as contributors are willing to help out 👍

WebReflection avatar Aug 01 '22 16:08 WebReflection

if you would like to provide a lazy accessor for history or others API, as long as it’s lazy and doesn’t change anything else around this project, I’d be more than happy to have a look, but if your goal is to have JS running within linkedom documents, I recommend you go back to JSDOM or use cypress, puppeteer, or others solutions.

This is exactly my use-case, I'm trying to SSR an Angular app with Linkedom (which I have been surprisingly successful with - it's quite fast too!) But I had to make some amendments to get there.

I figured, since this was such an amendment specifically for that use case it was out of the scope of this library.

damienwebdev avatar Aug 03 '22 01:08 damienwebdev

@damienwebdev I don't know why you brought that quote here in a completely unrelated issue ... my answer here was about you needing to send a PR to apply that change that has nothing to do with what you quoted there.

If you won't do that, it's OK, close this again, and let's move forward ... if you do, please don't bring to this issue completely unrelated discussions as that doesn't help anyone, thank you.

WebReflection avatar Aug 03 '22 08:08 WebReflection