Andrea Giammarchi
Andrea Giammarchi
if you explicitly import `canvas` module you should be good to go, as that's used when available in this project: https://github.com/WebReflection/linkedom/blob/a4bf499f61bc74d19e472cd6acbecc5e19db8b97/commonjs/canvas.cjs#L1-L7
this "*smells like a PR*" 😄
> When is a fix for the warnings going to be released? When the PR lands
@rxliuli thanks for the hint ... it looks like that file could just go away entirely at this point as NodeJS 16 is long-time-ago LTS ... and if that's the...
@rxliuli fair enough ... PR to remove `performance` welcomed but I might do it myself soon as it's always a pleasure to drop legacy try catches and trust modern environments...
@rxliuli does `npm` or *bun* complain? I can't write apparently a package for all runtimes ... but if peerDependency is the way to go, I'd rather ask you to file...
> The culprit is htmlparser2, if I downgrade to v6.1.0 so ... this bug is for a library used by this repository? if that's the case, what are you expecting...
@thierryc its been like 10 years I don’t work at Twitter or don’t maintain this project + I only ever wrote and cared about the only part that never changed:...
@thierryc to be honest, after all the changes that happened and the re-branding, I don't even know why this space is still active ... it should be called `xemoji` eventually...
@dpgeorge sorry it took a while ... so, [all](https://github.com/WebReflection/not-so-weak/blob/main/esm/index.js#L54-L62) [checks](https://github.com/WebReflection/not-so-weak/blob/main/esm/index.js#L115-L123) in [here](https://github.com/WebReflection/not-so-weak/blob/main/esm/index.js#L176-L184) do the same. The module is 100% code covered via [this test](https://github.com/WebReflection/not-so-weak/blob/main/test/index.js) which runs via `node --expose-gc test/index.js`....