Andrea Giammarchi
Andrea Giammarchi
why not filing a PR instead? I don't mind naive implementations as long as not obtrusive for the fast-path use case and working reasonably well (and code-covered, of course).
not enough interest in this, closing until PR available.
there's no location here ... it's SSR: you define the location? add a global class would be my answer but that might not solve, right?
If location is exposed (can’t remember, sorry) then it’s ok to expose Location class. mind filing a PR?
actually ... [tests show that location](https://github.com/WebReflection/linkedom/blob/main/test/html/document.js#L72-L75) is something you pass along, so you can add Location globally, or should I check if location is available (passed) and return its proto...
Closing as no interest shown whatsoever for more than a month.
what's `document.appendChild` supposed to do there? you have a body, a head, why document to append scripts? just to be sure it's not an issue caused yet another time by...
those are two different code paths/logic ... one thing is `textContent = '...'` which is not changed in code (for what I could tell) the other is parseHTML with stuff...
Is this related to latest TS release? AFAIK many use this project with TS and few PRs landed already and they were happy. About design decisions if we’re talking TSDoc...
@jeremy-rifkin are you going to update the PR?