WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

text-spacing: text-spacing-trim: implement trim-all for complex path

Open vitorroriz opened this issue 1 year ago โ€ข 1 comments

918cd8a250b6df2f40f22e82429b9a47c97ff3c3

text-spacing: text-spacing-trim: implement trim-all for complex path
https://bugs.webkit.org/show_bug.cgi?id=281761
rdar://137795771

Reviewed by NOBODY (OOPS!).

Simple path (WidthIterator) already covers this behavior.
We should now do the same for the Complex path (ComplexTextController).

trim-all:
Set fullwidth opening punctuation, fullwidth closing punctuation, and fullwidth middle dot punctuation with half-width glyphs,
without regards for the position within the line nor for adjacent characters.

* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns):
* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::Font::halfWidthFont const):

https://github.com/WebKit/WebKit/commit/918cd8a250b6df2f40f22e82429b9a47c97ff3c3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  win
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช wpe-wk2 โœ… ๐Ÿงช win-tests
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โœ… ๐Ÿงช ios-wk2-wpt โŒ ๐Ÿงช mac-wk1 โœ… ๐Ÿ›  wpe-cairo
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โœ… ๐Ÿ›  gtk
โœ… ๐Ÿ›  vision โœ… ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿ›  vision-sim โœ… ๐Ÿงช mac-wk2-stress โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿงช vision-wk2 โœ… ๐Ÿงช mac-intel-wk2
โœ… ๐Ÿ›  tv โœ… ๐Ÿ›  mac-safer-cpp
โœ… ๐Ÿ›  tv-sim
โœ… ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

vitorroriz avatar Oct 18 '24 17:10 vitorroriz

Committed 286983@main (85ed15ffe2c7): https://commits.webkit.org/286983@main

Reviewed commits have been landed. Closing PR #35439 and removing active labels.

webkit-commit-queue avatar Nov 22 '24 22:11 webkit-commit-queue