Implement URLPatternInit support for URLPatternAPI
ce36d5e8aaae77d1d740a47597d944b9fa9ef843
Implement URLPatternInit support for URLPatternAPI https://bugs.webkit.org/show_bug.cgi?id=281711 rdar://138169179 Reviewed by NOBODY (OOPS!). URLPattern API spec for processing a URLPatternInit: https://urlpattern.spec.whatwg.org/#process-a-urlpatterninit * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/url-pattern/URLPattern.cpp: (WebCore::escapeStringForCharacters): (WebCore::escapeString): (WebCore::processBaseURLString): (WebCore::processInit): (WebCore::URLPattern::create): (WebCore::URLPattern::URLPattern): * Source/WebCore/Modules/url-pattern/URLPattern.h: * Source/WebCore/Modules/url-pattern/URLPatternCanonical.cpp: Added. (WebCore::isInvalidIPv6HostCodePoint): (WebCore::isAbsolutePathname): (WebCore::canonicalizeProtocol): (WebCore::canonicalizeUsername): (WebCore::canonicalizePassword): (WebCore::canonicalizeHost): (WebCore::canonicalizeIPv6Host): (WebCore::canonicalizePort): (WebCore::canonicalizeOpaquePath): (WebCore::canonicalizePath): (WebCore::canonicalizeSearch): (WebCore::canonicalizeHash): * Source/WebCore/Modules/url-pattern/URLPatternCanonical.h: Copied from Source/WebCore/Modules/url-pattern/URLPatternInit.h. * Source/WebCore/Modules/url-pattern/URLPatternInit.h: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj:
https://github.com/WebKit/WebKit/commit/ce36d5e8aaae77d1d740a47597d944b9fa9ef843
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/84c518fce9922a099cfa73ead33e171933e40a48)
Safer C++ Build #2511
:x: Found 1 new failure. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. (cc @rniwa)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/7c1c219e2f507e3a0e68a49f526e356afb8a77dc)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/ce36d5e8aaae77d1d740a47597d944b9fa9ef843)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/82fa902fa6929100d458f7f3a3c0d2c77433201f)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/379593e7a57983c6bcff98f3f8f4ee51dfb7bf4c)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/5aef4e136386bc8ed97c388c74b7fcb302d83f77)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/b1a5bf04db03e7737f7dba57e9e409ed6fa804ef)
Can you update the URLPatternAPIEnabled flag to
testableand update expectations for imported tests in this patch? It seems hard to validate the implementation of algorithms without any test.
The PR is already very large. I think we can investigate enabling the tests in a follow up. There isn't much that is working yet anyway.
Can you update the URLPatternAPIEnabled flag to
testableand update expectations for imported tests in this patch? It seems hard to validate the implementation of algorithms without any test.The PR is already very large. I think we can investigate enabling the tests in a follow up. There isn't much that is working yet anyway.
ok we can do it in followup then
EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/3c4d107563bc174fb9d7b881ac9b374925717796)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/1fdd6bf23d65d7439e9cb57b46a81854bc6628ce)
Committed 285640@main (1e937703de6a): https://commits.webkit.org/285640@main
Reviewed commits have been landed. Closing PR #35412 and removing active labels.
๐งช api-ios