WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard
verified publisher icon WebKit

Adopt more smart pointers in WebPageProxy (part 3)

Open RupinMittal opened this issue 1 year ago • 4 comments

49da39b6febb5c8ccd4f511485626c93ecb47bff

Adopt more smart pointers in WebPageProxy (part 3)
https://bugs.webkit.org/show_bug.cgi?id=281700
rdar://138149402

Reviewed by NOBODY (OOPS!).

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::protectedProcessPool const):
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::resourceDirectoryURL const): Deleted.
* Source/WebKit/UIProcess/PageLoadState.h:
(WebKit::PageLoadState::resourceDirectoryURL const):
* Source/WebKit/UIProcess/WebNavigationState.cpp:
(WebKit::WebNavigationState::navigation): Deleted.
* Source/WebKit/UIProcess/WebNavigationState.h:
(WebKit::WebNavigationState::navigation):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gpuProcessID const):
(WebKit::WebPageProxy::modelProcessID const):
(WebKit::WebPageProxy::sendWithAsyncReply):
(WebKit::WebPageProxy::hasSameGPUAndNetworkProcessPreferencesAs const):
(WebKit::WebPageProxy::backForwardCache const):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadSimulatedRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::recordAutomaticNavigationSnapshot):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::setRemoteInspectionNameOverride):
(WebKit::WebPageProxy::setUnderPageBackgroundColorOverride):
(WebKit::WebPageProxy::updateActivityState):
(WebKit::WebPageProxy::viewDidLeaveWindow):
(WebKit::WebPageProxy::updateThrottleState):
(WebKit::WebPageProxy::updateHiddenPageThrottlingAutoIncreases):
(WebKit::WebPageProxy::wheelEventHandlingCompleted):
(WebKit::WebPageProxy::receivedNavigationActionPolicyDecision):
(WebKit::WebPageProxy::shouldClosePreviousPage):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::supportsTextEncoding const):
(WebKit::WebPageProxy::sessionState const):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::supportsTextZoom const):
(WebKit::WebPageProxy::getContentsAsAttributedString):
(WebKit::WebPageProxy::didDestroyFrame):
(WebKit::WebPageProxy::setNetworkRequestsInProgress):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaJS):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):
(WebKit::WebPageProxy::didUpdateHistoryTitle):
(WebKit::trySOAuthorization):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
(WebKit::WebPageProxy::runOpenPanel):
(WebKit::WebPageProxy::setMuted):
(WebKit::WebPageProxy::resumeDownload):
(WebKit::WebPageProxy::downloadRequest):
(WebKit::WebPageProxy::backForwardAddItemShared):
(WebKit::WebPageProxy::showPopupMenuFromFrame):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::mouseEventHandlingCompleted):
(WebKit::WebPageProxy::keyEventHandlingCompleted):
(WebKit::WebPageProxy::willChangeProcessIsResponsive):
(WebKit::WebPageProxy::currentURL const):
(WebKit::WebPageProxy::currentResourceDirectoryURL const):
(WebKit::WebPageProxy::resetStateAfterProcessTermination):
(WebKit::WebPageProxy::tryReloadAfterProcessTermination):
(WebKit::WebPageProxy::willStartCapture):
(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
(WebKit::WebPageProxy::validateCaptureStateUpdate):
(WebKit::WebPageProxy::setShouldListenToVoiceActivity):
(WebKit::WebPageProxy::startMonitoringCaptureDeviceRotation):
(WebKit::WebPageProxy::stopMonitoringCaptureDeviceRotation):
(WebKit::WebPageProxy::rotationAngleForCaptureDeviceChanged):
(WebKit::WebPageProxy::pageWillLikelyUseNotifications):
(WebKit::WebPageProxy::showNotification):
(WebKit::WebPageProxy::cancelNotification):
(WebKit::WebPageProxy::clearNotifications):
(WebKit::WebPageProxy::endPrinting):
(WebKit::WebPageProxy::setOverlayScrollbarStyle):
(WebKit::WebPageProxy::requestAttachmentIcon):
(WebKit::WebPageProxy::speechSynthesisVoiceList):
(WebKit::WebPageProxy::speechSynthesisSpeak):
(WebKit::WebPageProxy::speechSynthesisCancel):
(WebKit::WebPageProxy::speechSynthesisResetState):
(WebKit::WebPageProxy::speechSynthesisPause):
(WebKit::WebPageProxy::speechSynthesisResume):
(WebKit::WebPageProxy::setOrientationForMediaCapture):
(WebKit::WebPageProxy::gpuProcessExited):
(WebKit::WebPageProxy::createRealtimeMediaSourceForSpeechRecognition):
(WebKit::WebPageProxy::shouldEnableLockdownMode const):
(WebKit::WebPageProxy::processForSite):
(WebKit::WebPageProxy::webPageIDInProcess const):
(WebKit::WebPageProxy::protectedPageLoadState const):
(WebKit::WebPageProxy::sendToWebPage):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
(WebKit::SpeechSynthesisData::protectedSynthesizer const):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::isResponsive const): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:

https://github.com/WebKit/WebKit/commit/49da39b6febb5c8ccd4f511485626c93ecb47bff

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

RupinMittal avatar Oct 18 '24 00:10 RupinMittal

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/7554664e8f03c453f07176d8847e1748653019d7)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios ✅ 🛠 mac   ~~🛠 wpe~~   ~~🛠 win~~
❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~   ~~🧪 win-tests~~
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   ~~🧪 api-mac~~   ~~🧪 api-wpe~~
❌ 🧪 ios-wk2-wpt   ~~🛠 wpe-cairo~~
❌ 🧪 api-ios   ~~🧪 mac-wk2~~   ~~🛠 gtk~~
  ~~🛠 vision~~ ⏳ 🧪 mac-AS-debug-wk2   ~~🧪 gtk-wk2~~
  ~~🛠 vision-sim~~ ✅ 🧪 mac-wk2-stress   ~~🧪 api-gtk~~
⏳ 🧪 vision-wk2   ~~🧪 mac-intel-wk2~~
❌ 🛠 tv   ~~🛠 mac-safer-cpp~~
  ~~🛠 tv-sim~~
  ~~🛠 watch~~
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 18 '24 00:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/6ef155d13da5c83ead45b69e5f21cad4a2ff17f6)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ❌ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🛠 wpe-cairo
⏳ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
✅ 🛠 vision   ~~🧪 mac-AS-debug-wk2~~ ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv   ~~🛠 mac-safer-cpp~~
❌ 🛠 tv-sim
❌ 🛠 watch
loading 🛠 watch-sim

webkit-early-warning-system avatar Oct 18 '24 01:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/49da39b6febb5c8ccd4f511485626c93ecb47bff)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 18 '24 05:10 webkit-early-warning-system

Safer C++ Build #2503

:warning: Found 1 fixed file! Please update expectations in Source/[WebKit/WebCore]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WebKit --UncountedCallArgsChecker UIProcess/WebPageProxy.h

webkit-ews-buildbot avatar Oct 18 '24 11:10 webkit-ews-buildbot

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/eb2755a7cd6eefd2ef9485176c554b47b5caaeb3)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Dec 19 '24 08:12 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/7232b798c35a42d6c742eb1c5c14a5e96f86416a)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~ ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   ~~🧪 mac-AS-debug-wk2~~ ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Dec 19 '24 17:12 webkit-early-warning-system

EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/4b504bebf8c93be7647a56e42b61de4157e4cad6)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~ ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  ~~🧪 api-ios~~ ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   ~~🧪 mac-AS-debug-wk2~~   ~~🧪 gtk-wk2~~
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   ~~🛠 playstation~~
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Dec 19 '24 19:12 webkit-early-warning-system

Committed 288118@main (5ebdb0cd30e4): https://commits.webkit.org/288118@main

Reviewed commits have been landed. Closing PR #35394 and removing active labels.

webkit-commit-queue avatar Dec 19 '24 20:12 webkit-commit-queue