WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard
verified publisher icon WebKit

Use different keychain attribute for passkey credential ID

Open aznair opened this issue 1 year ago • 13 comments

4c612ce1f2bb816614e7af2d1cdc0b6847d403f1

Use different keychain attribute for passkey credential ID
https://bugs.webkit.org/show_bug.cgi?id=281344
rdar://137771569

Reviewed by NOBODY (OOPS!).

Use kSecAttrAlias going forward, and if a query using this field fails then fall
back to kSecAttrApplicationLabel

* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(getAllLocalAuthenticatorCredentialsImpl):
(+[_WKWebAuthenticationPanel deleteLocalAuthenticatorCredentialWithGroupAndID:credential:]):
(+[_WKWebAuthenticationPanel setDisplayNameForLocalCredentialWithGroupAndID:credential:displayName:]):
(+[_WKWebAuthenticationPanel setNameForLocalCredentialWithGroupAndID:credential:name:]):
(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):
(+[_WKWebAuthenticationPanel exportLocalAuthenticatorCredentialWithGroupAndID:credential:error:]):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::produceHashSet):
(WebKit::LocalAuthenticator::getExistingCredentials):
(WebKit::LocalAuthenticator::processLargeBlobExtension):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
(WebKit::LocalAuthenticator::receiveException const):
(WebKit::LocalAuthenticator::deleteDuplicateCredential const):
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cleanUpKeychain):
(WTR::TestController::keyExistsInKeychain):

https://github.com/WebKit/WebKit/commit/e006883c9bf369619f91e1804db403d8184054a3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 loading 🧪 api-mac ⏳ 🧪 api-wpe
loading 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-cairo
loading 🛠 🧪 jsc ⏳ 🧪 api-ios loading 🧪 mac-wk2 ✅ 🛠 gtk
loading 🛠 🧪 jsc-arm64 loading 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
loading-orange 🛠 vision-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
⏳ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp ❌ 🧪 jsc-armv7-tests
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

aznair avatar Oct 11 '24 21:10 aznair

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/4c612ce1f2bb816614e7af2d1cdc0b6847d403f1)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 11 '24 22:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/6988f64a1b6ed420cfc8e41c157ba55e5d89e06f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac   ~~🛠 wpe~~   ~~🛠 win~~
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~   ~~🧪 win-tests~~
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   ~~🧪 api-wpe~~
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   ~~🛠 wpe-cairo~~
❌ 🧪 api-ios ❌ 🧪 mac-wk2   ~~🛠 gtk~~
❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2   ~~🧪 gtk-wk2~~
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress   ~~🧪 api-gtk~~
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
❌ 🛠 tv   ~~🛠 mac-safer-cpp~~
❌ 🛠 tv-sim
❌ 🛠 watch
  ~~🛠 watch-sim~~

webkit-early-warning-system avatar Oct 11 '24 22:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/09557f7c0e8c353829b77182f51dc510a0dda92a)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2   ~~🧪 gtk-wk2~~
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
❌ 🛠 tv ❌ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
❌ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 14 '24 14:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/db370f90d7bdb83e157ce539f7f0865a81778a6f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 14 '24 16:10 webkit-early-warning-system

Converting to draft while I make some adjustments that have become necessary due to changes in Keychain.

aznair avatar Oct 15 '24 17:10 aznair

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/3827807b64f32ba301c21b892f87f48b82729ae5)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac   ~~🛠 wpe~~ ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~ ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   ~~🧪 api-wpe~~
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64   ~~🛠 vision~~ ❌ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
  ~~🛠 vision-sim~~ ❌ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
❌ 🛠 tv   ~~🛠 mac-safer-cpp~~ ✅ 🧪 jsc-armv7-tests
  ~~🛠 tv-sim~~
  ~~🛠 watch~~
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 17 '24 15:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/eac1bb41589e51fc20154d0633b022646b9b16c9)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac   ~~🛠 wpe~~ ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~   ~~🧪 win-tests~~
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   ~~🧪 api-wpe~~
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   ~~🛠 wpe-cairo~~
✅ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2   ~~🛠 gtk~~
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2   ~~🧪 gtk-wk2~~
  ~~🛠 vision-sim~~ ❌ 🧪 mac-wk2-stress   ~~🧪 api-gtk~~
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
❌ 🛠 tv   ~~🛠 mac-safer-cpp~~ ✅ 🧪 jsc-armv7-tests
  ~~🛠 tv-sim~~
  ~~🛠 watch~~
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 17 '24 16:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/61926739ef54dd4f564bf765168b78388c7f7d7d)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   ~~🛠 wpe~~ ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 17 '24 17:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/91501b935ac73670ab44e1a8a61c0ada4a2de955)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   ~~🛠 wpe~~   ~~🛠 win~~
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~   ~~🧪 win-tests~~
✅ 🧪 webkitperl   ~~🧪 ios-wk2~~   ~~🧪 api-mac~~   ~~🧪 api-wpe~~
  ~~🧪 ios-wk2-wpt~~   ~~🧪 mac-wk1~~ ✅ 🛠 wpe-cairo
  ~~🛠 🧪 jsc~~ ⏳ 🧪 api-ios   ~~🧪 mac-wk2~~ ✅ 🛠 gtk
  ~~🛠 🧪 jsc-arm64~~   ~~🛠 vision~~ ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim   ~~🧪 mac-wk2-stress~~ ⏳ 🧪 api-gtk
  ~~🧪 vision-wk2~~ ⏳ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv   ~~🛠 mac-safer-cpp~~   ~~🧪 jsc-armv7-tests~~
  ~~🛠 tv-sim~~
  ~~🛠 watch~~
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 18 '24 04:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/d248c4f118a7a1110999717f2e602b0640521f89)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ❌ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 18 '24 04:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/60d2bd05ca62fe8609933a0ad06181442507d4e1)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   ~~🛠 ios~~ ✅ 🛠 mac   ~~🛠 wpe~~   ~~🛠 win~~
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~   ~~🧪 win-tests~~
✅ 🧪 webkitperl   ~~🧪 ios-wk2~~   ~~🧪 api-mac~~   ~~🧪 api-wpe~~
loading 🧪 webkitpy   ~~🧪 ios-wk2-wpt~~   ~~🧪 mac-wk1~~   ~~🛠 wpe-cairo~~
  ~~🛠 🧪 jsc~~   ~~🧪 api-ios~~   ~~🧪 mac-wk2~~   ~~🛠 gtk~~
  ~~🛠 🧪 jsc-arm64~~   ~~🛠 vision~~ ⏳ 🧪 mac-AS-debug-wk2   ~~🧪 gtk-wk2~~
  ~~🛠 vision-sim~~   ~~🧪 mac-wk2-stress~~   ~~🧪 api-gtk~~
⏳ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
  ~~🛠 tv~~   ~~🛠 mac-safer-cpp~~ ⏳ 🧪 jsc-armv7-tests
  ~~🛠 tv-sim~~
  ~~🛠 watch~~
  ~~🛠 watch-sim~~

webkit-early-warning-system avatar Oct 18 '24 15:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/22219a20d91bbda323641be878a34ed81df2f031)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 18 '24 16:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/e006883c9bf369619f91e1804db403d8184054a3)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   ~~🧪 wpe-wk2~~ ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   ~~🧪 api-wpe~~
loading 🧪 webkitpy   ~~🧪 ios-wk2-wpt~~ ✅ 🧪 mac-wk1   ~~🛠 wpe-cairo~~
✅ 🛠 🧪 jsc   ~~🧪 api-ios~~ ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 loading 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   ~~🧪 gtk-wk2~~
loading-orange 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2   ~~🧪 mac-intel-wk2~~ ✅ 🛠 jsc-armv7
✅ 🛠 tv   ~~🛠 mac-safer-cpp~~ ❌ 🧪 jsc-armv7-tests
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

webkit-early-warning-system avatar Oct 21 '24 19:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/8e85629ae62ed5f2366a21cb24f2e90747697613)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
⏳ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

webkit-early-warning-system avatar Oct 21 '24 21:10 webkit-early-warning-system

EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/afd314606349cf5522c1aa9e0f656d88376999b6)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64   ~~🛠 vision~~ ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
  ~~🛠 vision-sim~~ ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

webkit-early-warning-system avatar Oct 22 '24 17:10 webkit-early-warning-system

Committed 285575@main (1dc9ae6c1864): https://commits.webkit.org/285575@main

Reviewed commits have been landed. Closing PR #35070 and removing active labels.

webkit-commit-queue avatar Oct 23 '24 00:10 webkit-commit-queue