WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

[iOS] Camera track is sometimes muted/unmuted when starting to capture

Open youennf opened this issue 1 year ago โ€ข 1 comments

05c0e82b2712e5fec50610c7ddaa8798b4688975

[iOS] Camera track is sometimes muted/unmuted when starting to capture
https://bugs.webkit.org/show_bug.cgi?id=274211
rdar://125475254

Reviewed by NOBODY (OOPS!).

There is a race condition below WebKit between media endowment activation and camera start-u.
This sometimes triggers spurious notification of being muted on iOS.
We add a timer that will delay mute notifications at startup time for 1 second.

WIP, needs more testing.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::startupTimerFired):
(WebCore::AVVideoCaptureSource::startProducingData):
(WebCore::AVVideoCaptureSource::captureSessionIsRunningDidChange):

https://github.com/WebKit/WebKit/commit/05c0e82b2712e5fec50610c7ddaa8798b4688975

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช wpe-wk2
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โœ… ๐Ÿงช ios-wk2-wpt โœ… ๐Ÿงช mac-wk1 โณ ๐Ÿ›  wpe-skia
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โœ… ๐Ÿ›  gtk
โœ… ๐Ÿ›  tv โœ… ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2-stress โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

youennf avatar May 15 '24 13:05 youennf

Committed 278952@main (da808677339d): https://commits.webkit.org/278952@main

Reviewed commits have been landed. Closing PR #28593 and removing active labels.

webkit-commit-queue avatar May 18 '24 11:05 webkit-commit-queue