WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Adopt more smart pointers in LocalDOMWindow

Open rwlbuis opened this issue 1 year ago โ€ข 5 comments

f1382fc05401e66b15817eb1966fb47c8d2cd882

Adopt more smart pointers in LocalDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=273393

Reviewed by NOBODY (OOPS!).

Adopt more smart pointers in LocalDOMWindow based on the
[alpha.webkit.UncountedLocalVarsChecker] warning.

* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::allowsBeforeUnloadListeners):
(WebCore::LocalDOMWindow::allowPopUp):
(WebCore::LocalDOMWindow::isCurrentlyDisplayedInFrame const):
(WebCore::LocalDOMWindow::collectMatchingElementsInFlatTree):
(WebCore::LocalDOMWindow::matchingElementInFlatTree):
(WebCore::LocalDOMWindow::processPostMessage):
(WebCore::LocalDOMWindow::closePage):
(WebCore::LocalDOMWindow::origin const):
(WebCore::LocalDOMWindow::securityOrigin const):
(WebCore::LocalDOMWindow::showModalDialog):

https://github.com/WebKit/WebKit/commit/f1382fc05401e66b15817eb1966fb47c8d2cd882

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช wpe-wk2
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โœ… ๐Ÿงช ios-wk2-wpt โœ… ๐Ÿงช mac-wk1 โณ ๐Ÿ›  wpe-skia
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โœ… ๐Ÿ›  gtk
โœ… ๐Ÿ›  tv โœ… ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2-stress โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

rwlbuis avatar Apr 29 '24 10:04 rwlbuis

Committed 281244@main (b838f8bb3573): https://commits.webkit.org/281244@main

Reviewed commits have been landed. Closing PR #27866 and removing active labels.

webkit-commit-queue avatar Jul 23 '24 15:07 webkit-commit-queue