WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

[build-webkit-org] Add steps for running smart pointer static analysis in Buildbot

Open briannafan opened this issue 1 year ago โ€ข 19 comments

574340678e0c735d0571787b8204fa286dcced1d

[build-webkit-org] Add steps for running smart pointer static analysis in Buildbot
https://bugs.webkit.org/show_bug.cgi?id=272998
rdar://problem/126761949

Reviewed by NOBODY (OOPS!).

Add new steps that run static analysis with the --smart-pointer-only flag and organize the results for human consumption.

* Tools/CISupport/build-webkit-org/steps.py:
(ArchiveStaticAnalyzerResults): Changes output and dest paths.
(UploadStaticAnalyzerResults): Changes source path.
(ScanBuildSmartPointer): Runs build-and-analyze with --only-smart-pointers enabled.
(ParseStaticAnalyzerResults): Runs generate-dirty-files.py to get current lists of dirty files and UUIDs of bugs.
(CompareStaticAnalyzerResults): Runs compare-static-analysis-results.py to compare current and previous dirty files.
(UpdateSmartPointerBaseline): Updates baseline to current run's results.
(TransferToS3.doStepIf):
(ExtractTestResults):
(ExtractTestResults.resultDownloadURL): Add URL for downloading results.
(ExtractStaticAnalyzerTestResults): Modify paths for scan-build results.
(ExtractStaticAnalyzerTestResults.getLastBuildStepByName):
(ExtractStaticAnalyzerTestResults.addCustomURLs):

* Tools/CISupport/build-webkit-org/steps_unittest.py:
(TestScanBuildSmartPointer): Added.
(TestParseStaticAnalyzerResults): Added.
(TestCompareStaticAnalyzerResults): Added.
(TestUpdateSmartPointerBaseline): Added.

https://github.com/WebKit/WebKit/commit/574340678e0c735d0571787b8204fa286dcced1d

Misc iOS, tvOS & watchOS macOS Linux Windows
โณ ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โณ ๐Ÿ›  wincairo
loading ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โณ ๐Ÿงช wpe-wk2
โณ ๐Ÿงช webkitperl loading ๐Ÿงช ios-wk2 loading ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โณ ๐Ÿงช ios-wk2-wpt โœ… ๐Ÿงช mac-wk1 โณ ๐Ÿ›  wpe-skia
โณ ๐Ÿ›  ๐Ÿงช jsc โณ ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โŒ ๐Ÿ›  gtk
โณ ๐Ÿ›  tv โณ ๐Ÿงช mac-AS-debug-wk2 โŒ ๐Ÿงช gtk-wk2
โœ… ๐Ÿงช services โณ ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2-stress โŒ ๐Ÿงช api-gtk
โณ ๐Ÿ›  watch
โณ ๐Ÿ›  watch-sim

briannafan avatar Apr 19 '24 18:04 briannafan

Successful test run: https://build.webkit-uat.org/#/builders/761/builds/432

briannafan avatar May 16 '24 21:05 briannafan

Committed 278895@main (dbbdbf11bdfc): https://commits.webkit.org/278895@main

Reviewed commits have been landed. Closing PR #27530 and removing active labels.

webkit-commit-queue avatar May 16 '24 23:05 webkit-commit-queue