WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

remove getRGBAImageData refs

Open raiyansayeed opened this issue 3 years ago • 2 comments

5ceba47572e5da6d8f73d7bc9ab2be46e4ad0f18

Need a short description (OOPS!).
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

* Source/WebCore/platform/VideoFrame.cpp:
(WebCore::VideoFrame::initializeCharacteristics):
(WebCore::VideoFrame::getRGBAImageData const): Deleted.
* Source/WebCore/platform/VideoFrame.h:
* Source/WebCore/platform/VideoFrame.mm:
(WebCore::VideoFrame::getRGBAImageData const): Deleted.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::videoFrameAvailable):

This commit include:

refactor: move function to Internals.cpp

Remove VideoFrame::getRGBAImageData()
https://bugs.webkit.org/show_bug.cgi?id=240115

Reviewed by NOBODY (OOPS!).

* Source/WebCore/platform/VideoFrame.cpp:
(WebCore::VideoFrame::initializeCharacteristics):
(WebCore::VideoFrame::getRGBAImageData const): Deleted.
* Source/WebCore/platform/VideoFrame.h:
* Source/WebCore/platform/VideoFrame.mm:
(WebCore::VideoFrame::getRGBAImageData const): Deleted.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::videoFrameAvailable):

This patch deletes references to VideoFrame::getRGBAImageData() and refactors existing code to use other overloads.

raiyansayeed avatar Jul 09 '22 15:07 raiyansayeed

I think the git-webkit script I ran auto-requested a review but the PR is still not ready 😅

raiyansayeed avatar Jul 16 '22 03:07 raiyansayeed

I think the git-webkit script I ran auto-requested a review but the PR is still not ready 😅

You can switch it to a "draft" pull-request. Once a PR is created, you can do that. through GitHub's UI. Before a PR is created, you can do that with git-webkit pr --draft

JonWBedard avatar Jul 16 '22 14:07 JonWBedard