Speedometer icon indicating copy to clipboard operation
Speedometer copied to clipboard

Don't display invalid results

Open camillobruni opened this issue 1 year ago • 5 comments

This partially fixes #399 by not display non-finite scores which are caused by 0-measured suite results.

  • For non-positive or non-finite scores, the following summary page is displayed. Note that the detailed page is still accessible since you might find some useful information there.
  • Additionally a console.error is generated for each zero-sum suite
Screenshot 2024-04-08 at 11 17 26

camillobruni avatar Apr 08 '24 13:04 camillobruni

should we display a message to the user, explaining what happened and that the details view might have useful information?

flashdesignory avatar Apr 08 '24 14:04 flashdesignory

Updated version with a better description: Screenshot 2024-04-08 at 16 57 52

camillobruni avatar Apr 08 '24 14:04 camillobruni

Rather than "Invalid Score", how about "Error"? Also, we should probably stop right away when we detect an invalid value instead of running 'til completion.

rniwa avatar Apr 08 '24 19:04 rniwa

Screenshot 2024-04-09 at 11 04 00

camillobruni avatar Apr 09 '24 09:04 camillobruni

Updated the code to stop after the first iteration with a broken score (tracking errors across the TestInvoker seems a bit more tricky at the moment).

camillobruni avatar Apr 09 '24 09:04 camillobruni

@rniwa could you have another look maybe?

camillobruni avatar May 30 '24 15:05 camillobruni

@rniwa do you have additional feedback or would be ok with landing with your proposed changes?

camillobruni avatar Jun 05 '24 10:06 camillobruni