wasm-c-api icon indicating copy to clipboard operation
wasm-c-api copied to clipboard
verified publisher icon WebAssembly

C API: u8 in Rust corresponds to unsigned char* in C

Open dannywillems opened this issue 2 years ago • 5 comments

Related to https://github.com/wasmerio/wasmer/pull/3597/

dannywillems avatar Feb 23 '23 22:02 dannywillems

Wouldn't it be more appropriate to fix the typedef for byte_t instead?

rossberg avatar Feb 24 '23 06:02 rossberg

I thought about it. byte_t is used in different places, and I didn't know if it would impact a lot of the codebase/users.

If you confirm it is fine, I agree with changing.

dannywillems avatar Feb 24 '23 08:02 dannywillems

@rossberg thoughts on this 👆?

syrusakbary avatar Mar 20 '23 02:03 syrusakbary

Yes, confirmed. Thanks. :)

rossberg avatar Mar 20 '23 18:03 rossberg

@dannywillems should we update then the byte_t typedef so this PR can be merged?

syrusakbary avatar Aug 25 '23 21:08 syrusakbary