wasi-testsuite icon indicating copy to clipboard operation
wasi-testsuite copied to clipboard

add a dumb timeout logic

Open yamt opened this issue 2 years ago • 3 comments

issue: https://github.com/WebAssembly/wasi-testsuite/issues/42

a few notes on this implementation:

  • the timeout is hardcoded to 3 seconds for now. we can add a configuration in per-test json files when necessary.
  • unit test doesn't cover the new code. i have no plan to write tests at this point.
  • adapters may need something like https://github.com/yamt/toywasm/pull/117 for better cleanup

yamt avatar Aug 28 '23 11:08 yamt

@loganek please review when you have time. this is not urgent for me.

yamt avatar Sep 08 '23 00:09 yamt

Thanks for the change, and sorry for being late with the review. I'll try to get to it by end of this week.

loganek avatar Sep 11 '23 19:09 loganek

@loganek ping

yamt avatar Jan 29 '24 10:01 yamt