exception-handling icon indicating copy to clipboard operation
exception-handling copied to clipboard

Modified the throw context example with concrete types but not concrete values.

Open ioannad opened this issue 3 years ago • 3 comments

Addresses @aheejin's request in a previous review comment: https://github.com/WebAssembly/exception-handling/pull/180#discussion_r955477590

Originally I wrote this using

  • val_{i32} = (i32.const 1),
  • val_{f32} = (f32.const 2.0), and
  • val_{i64} = (i64.const 3),

but the example seemed then really long. To keep the example relatively short I switched to the current version.

ioannad avatar Sep 01 '22 14:09 ioannad

@aheejin is the example clear enough now or do you think it's better to use the concrete values, so (i32.const 1) instead of val_{i32} etc?

ioannad avatar Sep 01 '22 14:09 ioannad

@rossberg incidentally, this also addresses your previous comment about using "let ... be .. ".

ioannad avatar Sep 01 '22 16:09 ioannad

All review comments should be addressed now, pending for approval.

ioannad avatar Oct 13 '22 17:10 ioannad