binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

[emscripten] Enable WASM_BIGINT by default

Open sbc100 opened this issue 3 months ago • 4 comments

This flag has been enabled by default in emscripten for a while now so I don't think we need this here anymore.

Also remove the -Wno-experimental flag which is no longer needed for -sMEMORY64.

Also remove -sMODULARIZE which is implied by -sEXPORT_ES6.

sbc100 avatar Oct 22 '25 22:10 sbc100

Hm.. it looks like more work is requires to make the binaryen API bigint friendly. @kripken did you take a look at this in the past?

sbc100 avatar Oct 24 '25 00:10 sbc100

Hmm, no, I don't recall doing that.

More generally, my hope is we can move binaryen.js to embind so stuff like this is handled automatically.

kripken avatar Oct 24 '25 00:10 kripken

Hmm, no, I don't recall doing that.

More generally, my hope is we can move binaryen.js to embind so stuff like this is handled automatically.

It seems like there are places where the API uses 64-bit stuff and is not expecting it to simply use bigints

sbc100 avatar Oct 24 '25 00:10 sbc100

I decided to look into the changes needed to the JS API.. WDYT?

sbc100 avatar Oct 24 '25 20:10 sbc100