binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

Allow multiple patterns for noinline

Open DirtyHairy opened this issue 1 year ago • 3 comments

I have multiple function patterns that I would like to exclude from inlining. Unfortunately, the noinline pass only allows a single pattern, which does not allow any conditionals. It would be great if there were a way to specify multiple patterns, either by extending the pattern syntax or by allowing multiple instances of the noinline pass.

I can provide a PR for either of these options if desired 😏

DirtyHairy avatar Jun 08 '24 20:06 DirtyHairy

Sounds reasonable to me. Maybe see if there's a simple way to allow multiple instances of the noinline pass, as that sounds best (but I'm not sure how simple it would be, offhand - we'd need to track the pass argument per instance of the pass, I guess).

kripken avatar Jun 10 '24 16:06 kripken

Alright, I'll look into it.

DirtyHairy avatar Jun 11 '24 20:06 DirtyHairy

I opened #6687 .

DirtyHairy avatar Jun 20 '24 08:06 DirtyHairy