binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

Validate function imports

Open kripken opened this issue 2 years ago • 1 comments

We validate functions in parallel, but function-parallel passes do not run on imports, so we did not issue a validation error on an import using a disallowed type, for example.

All the changes in visitFunction are just to group all the parts using body to the end, and putting them behind a check for body.

(diff without whitespace is smaller)

Found using #6310 #6312

kripken avatar Feb 15 '24 17:02 kripken

function-parallel passes do not run on imports

I wonder where else we are messing this up...

tlively avatar Feb 16 '24 01:02 tlively