binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

Remove legacy GC encodings

Open tlively opened this issue 2 years ago • 3 comments

It was previously possible to opt in to using the legacy GC opcodes with a build time flag. Now that WasmGC has shipped and users have migrated to the standard opcodes, remove the option to use the legacy encodings.

tlively avatar Aug 10 '23 20:08 tlively

  • #5874 Graphite 👈
  • #5873 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlively and the rest of your teammates on Graphite Graphite

tlively avatar Aug 10 '23 20:08 tlively

This is meant to be landed after the GC proposal goes to phase 4 and the proposal has shipped by default in browsers that previously supported the legacy encodings. In the time between those two events, users can still choose at Binaryen build time whether they want to target the GC experiment on stable browsers using the legacy encodings or newer pre-release versions of browsers that support the standard encodings.

tlively avatar Aug 10 '23 21:08 tlively

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.46%. Comparing base (b671b6c) to head (9118d78).

:exclamation: Current head 9118d78 differs from pull request most recent head d475502. Consider uploading reports for the commit d475502 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5874      +/-   ##
==========================================
- Coverage   48.86%   42.46%   -6.41%     
==========================================
  Files         511      482      -29     
  Lines       78407    74725    -3682     
  Branches    12410    11931     -479     
==========================================
- Hits        38312    31730    -6582     
- Misses      36671    39787    +3116     
+ Partials     3424     3208     -216     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 10 '23 21:08 codecov[bot]

I'm going to go ahead and land this once the tests have passed.

tlively avatar Mar 12 '24 18:03 tlively