BloodMagic icon indicating copy to clipboard operation
BloodMagic copied to clipboard

[1.20.1 Alpha] - Missing death message

Open ToxinZangoose opened this issue 2 years ago • 3 comments

Tiny bug with death messages that writes "death.attack.sacrifice" This happened on a server, planning to report the bug to him once he returns.

Missing message about cause of player death other than the tag for it.

A (humorous) message saying "IntegoChao died from self sacrifice, pity."

  1. Attempt to fill your soul network with LP.
  2. Accidentally use too much.
  3. Error with death message appears.

  • BloodMagic: 1.20.1 3.3.1-43
  • Minecraft: 1.20.1
  • Forge: 47.2.0

ToxinZangoose avatar Oct 02 '23 21:10 ToxinZangoose

Can confirm. Happens due to the lang file not having an entry.

FoxMcloud5655 avatar Oct 02 '23 22:10 FoxMcloud5655

Must have been a small error when porting the GeneratorLanguage

WayofTime avatar Oct 02 '23 22:10 WayofTime

DamageSources have changed in 1.20. They are datapack-able and have been decoupled with cause of death. That is why it broke (and I missed it). #1984 is the correct way to do it now

dphaldes avatar Oct 08 '23 07:10 dphaldes