rsync: failed verification -- update retained - no symlinks regression from CVE fixes

[sylvain-ilm]

Hi, Since rsync 3.4.1 (on both Ubuntu 22.04 & FreeBSD 14 systems), I've got a bunch of those :

>f..t....... DB/psql/databases/225367/235949.dat
WARNING: DB/psql/databases/225367/235949.dat failed verification -- update retained (will try again).

Reverting the receiver to 3.3.0 (on both Ubuntu & FreeBSD) does fix the problem.

Contrary to #715, no symlinks are involved. I suppose the "update retained" vs "update discarded" is because of --inplace --no-whole-file.

Here's the command line :

rsync -aviz --numeric-ids --stats --timeout 600 --exclude logs --exclude Cache --partial --inplace --no-whole-file -b --backup-dir /tmp/rsync_backup-dir6352252118121511819 --delete-delay --delete-excluded --max-delete 10000 --copy-dest=/data/Sauvegarde/data/std/.zfs/snapshot/2025-01-23T03:00:00Z fqdn::std/ /data/Sauvegarde/data/std

Cheers