wayfire GTK4 Window not decorated

Describe the bug GTKMM-4.0 Window not being decorated despite having forced the window to have client side decorations in code. Wayfire configured to support client side decorations.

To Reproduce Steps to reproduce the behavior: compile program from https://github.com/DMJC/ffdstudio run on wayfire with client side decorations enabled in wayfire.

Expected behavior Minimise/maximise/close buttons and window frame expected to appear on window.

Screenshots or stacktrace

Wayfire version 0.9.0 debian 13 Trixie

Mar 02 '24 22:03 DMJC

It seems this client (and maybe all gtk4 clients?) try to negotiate decorations before mapping and wayfire isn't expecting this. Does this patch help?

Mar 07 '24 03:03 soreau

Also, it is noteworthy that setting preferred_decoration_mode to client will ask the client to render its own decorations. Setting it to server will ask the client to not decorate itself and wayfire will apply decorations instead, so long as you have a decoration plugin enabled. In my tests, setting client mode made the client draw its own decorations. The patch fixes the case with server mode, so the client gets server side decorations from wayfire decoration plugin.

Mar 07 '24 04:03 soreau