docs icon indicating copy to clipboard operation
docs copied to clipboard

Update hello_world.md

Open ahndmal opened this issue 2 years ago • 6 comments

delete wrong extra tick sign in CLI code

Explanation

Correct the CLI cocde in docs.

Related issue

No existing issue

What type of PR is this

/kind documentation

Proposed Changes

Correct the CLI cocde in docs.

ahndmal avatar Oct 21 '23 12:10 ahndmal

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

The Pull Request titled "Update hello_world.md" contains several key changes that improve the clarity and correctness of the document. These changes include removing an extra tick sign in the CLI code, updating the Go installation link to the official Go website, and fixing formatting by adding a colon after the --reactor mode.

Upon reviewing the individual summaries provided, it is evident that there are no potential problems or errors identified in this patch. The changes appear to be straightforward and enhance the overall quality of the document.

Important Findings:

  • The key changes focus on improving clarity and correctness.
  • The removal of an extra tick sign in the CLI code enhances the accuracy of the provided code snippet.
  • The update of the Go installation link to the official Go website ensures that users are directed to the most reliable and up-to-date resource.
  • The fix in formatting by adding a colon after the --reactor mode improves the readability and consistency of the document.

Based on the provided information, the Pull Request seems to be a valuable contribution and can be merged into the codebase without any potential issues.

Details

Commit 6fd39b2e386036742eed4e76cf9db2509f93f75e

Key changes:

  • Remove an extra tick sign in the CLI code.
  • Update the Go installation link to the official Go website.
  • Fix formatting by adding a colon after the --reactor mode.

Potential problems:

  • There are no potential problems identified in this patch. The changes appear to be straightforward and improve the clarity and correctness of the document.

Commit 41033e1722dfc573bd796cb5f4de39baf42e6452

Key changes:

  • A semicolon in the line "For the --reactor mode" has been changed to a comma.

Potential problems:

  • No potential problems have been identified in this patch.

alabulei1 avatar Oct 21 '23 12:10 alabulei1

The DCO check failed. Please refer to this for signing DCO: https://www.secondstate.io/articles/dco/

hydai avatar Oct 21 '23 13:10 hydai

@ahndmal Could you please sign-off your commits? More info on how to: https://github.com/WasmEdge/docs/pull/178/checks?check_run_id=17924620845

adithyaakrishna avatar Oct 21 '23 13:10 adithyaakrishna

Signed the commits. Please also note that https://www.secondstate.io/articles/dco/ page seems to have incorrect flags in: git commit —amend —no-edit ---signoff to be git commit --amend --no-edit --signoff

ahndmal avatar Oct 22 '23 09:10 ahndmal

Please squash your commits. One of your commits is not DCO-signed.

hydai avatar Oct 26 '23 11:10 hydai

Hi @ahndmal

Could you please take a look at the DCO issue? It still fails. Thanks!

alabulei1 avatar Jan 25 '24 11:01 alabulei1

Due to the DCO not being signed, we are not able to merge this PR. Closing it for now. Please feel free to re-submit a new PR if the DCO is signed.

hydai avatar Jun 13 '24 08:06 hydai