Investigate discrepancies in spritesheets per nations

[Dune-jr]

from @FunctionDJ in Discord:

i have a task for someone

• check out https://github.com/DeamonHunter/AWBW-Replay-Player
• the Archive.zip file contains my generated spritesheet JSON files from the AWBW-Replay-Player files for the official nations (references AWBW-Replay-Player/AWBWApp.Resources/Textures/ [Map/AW2, Unit] /[Nation]/
• compare my generated spritesheets to each other (using vscode Compare with or diffcheck.io or whatever you want)
• compile the differences and figure out why some sprites are missing or why sizes differ
• ideally propose fixes to make the official nation sprites all the same

for example: why does black hole has one more clear-weather airport frame than yellow comet?

[Dune-jr]

So from what I can tell the files from the archive of @FunctionDJ are just linted versions of what can be found here: https://github.com/WarsWorld/WarsWorld/tree/main/public/img/spriteSheet

The discrepancies can be seen for example here: https://github.com/WarsWorld/WarsWorld/blob/c111948cc1e728063e45e6ccbc93b196cfcb32b6/public/img/spriteSheet/black-hole.json#L1-L18 https://github.com/WarsWorld/WarsWorld/blob/c111948cc1e728063e45e6ccbc93b196cfcb32b6/public/img/spriteSheet/yellow-comet.json#L1-L18

I mentioned this in this Discord thread: https://discord.com/channels/1097616229210001508/1232781104117846137

So different nations can be animated on two frames, three frames, etc. You can tell the airport in your example "breathes" and the top gets slightly inflated. Slider view:

the diffcheck on the image gives

so we're going to have different animations sizes/framecount for different nations, which is to be expected. On top of having a list of resources, we might need to generate some json info to group the animation frames, mention the counts difference etc. won't be too hard to standardize this with a proper format, we don't need to have all nations kept to the same framecount

[Dune-jr]

Information on how to animate (frame count, timings) is described in https://github.com/DeamonHunter/AWBW-Replay-Player/blob/master/AWBWApp.Resources/Json/Buildings.json (and other JSONs in https://github.com/DeamonHunter/AWBW-Replay-Player/tree/master/AWBWApp.Resources/Json for the other resources).

Different units or nations can animate things differently

We already have the information on how to group different sprites belonging to the same animation in the JSON you pointed at here: https://github.com/WarsWorld/WarsWorld/blob/c111948cc1e728063e45e6ccbc93b196cfcb32b6/public/img/spriteSheet/black-hole.json#L2503-L2527

Is there anything else or this issue can be closed as resolved? @FunctionDJ

[FunctionDJ]

@Dune-jr i think i'd like to keep the issue open until we've at least talked to DaemonHunter once.

[Dune-jr]

I've been trying to get a hold of him as well. Should also ask him to use his ripped assets, for courtesy if anything, and talk about potentially moving them to a shared repo of resources