web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

Chore: add script to check version mismatch postinstall

Open svenvoskamp opened this issue 7 months ago • 7 comments

Description

Chore: add script to check version mismatch postinstall

I tested it with the following config in lab:

 "@reown/appkit": "workspace:*",
 "@reown/appkit-adapter-ethers": "1.7.0",
 "@reown/appkit-adapter-wagmi": "1.6.9",

Result:

Reown AppKit version mismatch detected!
│    Expected all @reown/appkit packages to be version 1.7.9
│    Mismatched packages:
│      • @reown/appkit-adapter-ethers: 1.7.0 (expected 1.7.9)
│      • @reown/appkit-adapter-wagmi: 1.6.9 (expected 1.7.9)
│    Please update all @reown/appkit packages to version 1.7.9
│    You can run the following commands:
│      npm install @reown/[email protected]
│      npm install @reown/[email protected]
└─ Failed in 146ms

Happy path:

installed @reown/appkit packages and versions:
│   @reown/appkit: 1.7.10
|   @reown/appkit-adapter-bitcoin: 1.7.10
│   @reown/appkit-adapter-ethers: 1.7.10
│   @reown/appkit-adapter-ethers5: 1.7.10
│   @reown/appkit-adapter-solana: 1.7.10
│   @reown/appkit-adapter-wagmi: 1.7.10
│   @reown/appkit-common: 1.7.10
│   @reown/appkit-experimental: 1.7.10
│   @reown/appkit-siwe: 1.7.10
│   @reown/appkit-siwx: 1.7.10
│   @reown/appkit-wallet: 1.7.10
│   @reown/appkit-wallet-button: 1.7.10
│   @reown/appkit-pay: 1.7.10
└─ Done in 87ms appkit packages are in sync (1.7.10)

Type of change

  • [ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

  • [ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [ ] My changes generate no new warnings
  • [ ] I have reviewed my own code
  • [ ] I have filled out all required sections
  • [ ] I have tested my changes on the preview link
  • [ ] Approver of this PR confirms that the changes are tested on the preview link

svenvoskamp avatar Jun 17 '25 09:06 svenvoskamp

🦋 Changeset detected

Latest commit: 2d2b23d1ad1ec993d21c3d2e7a61b5f8e228f62e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch
@reown/appkit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 17 '25 09:06 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 3:04pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 3:04pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 3:04pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 3:04pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jun 17, 2025 3:04pm

vercel[bot] avatar Jun 17 '25 09:06 vercel[bot]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​wagmi/​vue@​0.1.22851007597100

View full report

socket-security[bot] avatar Jun 17 '25 09:06 socket-security[bot]

Warnings
:warning:

🔑 Potential High‑entropy string detected in packages/appkit/package.json (line 37): dist/types/exports/l...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit/package.json (line 37): dist/types/exports/l...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 18): HPAccp9wmUAP4kxATmf1...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit-utils/tests/WalletConnectWalletStandard.test.ts (line 85): 5eykt4UsFv8P8NJdTREp...

Generated by :no_entry_sign: dangerJS against 2d2b23d1ad1ec993d21c3d2e7a61b5f8e228f62e

github-actions[bot] avatar Jun 17 '25 09:06 github-actions[bot]

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 76.94% 29259 / 38024
🔵 Statements 76.94% 29259 / 38024
🔵 Functions 68.2% 2454 / 3598
🔵 Branches 84.03% 5969 / 7103
File CoverageNo changed files found.
Generated in workflow #12703 for commit 2d2b23d by the Vitest Coverage Report Action

github-actions[bot] avatar Jun 17 '25 09:06 github-actions[bot]

@svenvoskamp what happens when postinstall fails. is it blocking for the dev?

@rocky yes it blocks the install, see process.exit(1), I can remove that one?

Will add a try catch, so it never blocks the dev if it fails and can also remove the process.exit, but then it might get easily ignored tho

svenvoskamp avatar Jun 17 '25 11:06 svenvoskamp