web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

[bug] Unwanted analytics sent by the V5 version

Open busimus opened this issue 1 year ago • 2 comments

Link to minimal reproducible example

https://stackblitz.com/edit/web3modal-analytics-repro?file=src%2FApp.tsx

Summary

web3modal sends a lot of analytics to Datadog, Segment, LaunchDarkly (originating from dynamic scripts loaded from magic.link, I think) even when analytics are disabled in the config. Previously in V4 it was possible to disable this by setting enableEmail to false. In V5 that parameter was removed and replaced with the auth object, but setting its email field to false has no effect, it only visually disables the email feature.

Here's a screenshot of the 3rd party requests sent by the V5 version from the repro example (thankfully those requests were blocked by adblock):

And here's a similar screenshot but for the V4 version of the same code (with enableEmail: false):

Ideally I want to keep the ability to use email wallets without unnecessary analytics being sent but I'll settle for just being able to disable them both. And I checked, email wallets work fine with all of those requests blocked, so they're definitely not necessary.

(the reproducible example doesn't run in the browser because I assume WalletConnect SDK requests encounter this error: (blocked:NotSameOriginAfterDefaultedToSameOriginByCoep), so you need to download the project code from stackblitz and run it locally)

List of related npm package versions

"@web3modal/ethers": "5.0.3", "ethers": "6.9.0",

busimus avatar Jun 27 '24 08:06 busimus

same here

elix1er avatar Jun 29 '24 14:06 elix1er

Seems like a dup of https://github.com/WalletConnect/web3modal/issues/2151

In any case the issue is annoying.

Toomaie avatar Jul 23 '24 12:07 Toomaie

Also having this issue image

RJKerry avatar Jul 24 '24 16:07 RJKerry