web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

[feature request] Customize all WalletConnect options while initialize `createModal`

Open yulafezmesi opened this issue 1 year ago • 6 comments

What problem does this new feature solve?

as far as i can see, currently not possible to pass optionalMethods and all other optiona to initialize walletconnect eth. provider. can we make this possible?

https://github.com/WalletConnect/web3modal/blob/V4/packages/ethers5/src/client.ts#L383

Describe the solution you'd like

create a new contractor object named like ethereumProviderOptions, and pass into walletconnect eth. provider.

private ethereumProviderOptions: EthereumProviderOptions | undefined = undefined

yulafezmesi avatar Apr 22 '24 07:04 yulafezmesi

Is there any particular method you'd like to add? We add all the Ethereum methods by default

glitch-txs avatar Apr 22 '24 07:04 glitch-txs

we have special integration with Avocado Wallet and Avocado handling custom methods like avocado_getOwner or avocado_sendTransaction. this was possible with legacy Web3Modal, but currently is not possible. (we're migrating to v4)

edit: if i don't pass the optional method names, throwing method not found err

image

yulafezmesi avatar Apr 22 '24 07:04 yulafezmesi

Ahh this is only supported when used with Wagmi atm

glitch-txs avatar Apr 22 '24 12:04 glitch-txs

i see. can be possible for ethers5 as well? i'm willing to created PR if sounds good you.

yulafezmesi avatar Apr 22 '24 16:04 yulafezmesi

we will refactor the connectors logic, once that's done we can add it I think.

cc @svenvoskamp

glitch-txs avatar Apr 22 '24 21:04 glitch-txs