web3modal-react-native icon indicating copy to clipboard operation
web3modal-react-native copied to clipboard

[feature] Upgrade @web3modal/core-react-native to valtio 1.11.2

Open thiagobrez opened this issue 2 years ago • 3 comments

What problem does this new feature solve?

Would be good to have standard versions of valtio across the web and native packages, to avoid https://github.com/WalletConnect/web3modal-react-native/issues/79 happening when installing both web and native SDKs for a cross-platform setup

Screenshot 2023-12-18 at 13 38 43

Describe the solution you'd like

Yes, pinning a version with resolutions field in package.json works, but preferably we wouldn't need to do that when installing both SDKs from Web3Modal

Bump valtio in @web3modal/core-react-native to 1.11.2, to match version in other Web3Modal packages

thiagobrez avatar Dec 18 '23 13:12 thiagobrez

Hi @thiagobrez 👋 last time i tried to upgrade valtio to 1.11.2 it had an issue with Hermes.

Here is more context in Valtio's repo -> https://github.com/pmndrs/valtio/issues/765

Did you have this error while you were using the sdk?

ignaciosantise avatar Jan 10 '24 17:01 ignaciosantise

Hey @ignaciosantise ! Yeah that makes sense. I got the error when trying to install both the Web3Modal web and react native SDKs on the same project, for a cross-platform approach, such as in https://github.com/callstack/web3-cross-platform-dapp

I solved by adding the resolutions field to package, but ideally when the issue with Hermes is solved, I think this should be handled in the SDK

thiagobrez avatar Jan 10 '24 18:01 thiagobrez

Of course, once the issue is solved in Hermes code, i'll bump valtio 🤝

Im curious why you didn't have issues with Hermes using valtio 1.11.2 🤔

ignaciosantise avatar Jan 10 '24 18:01 ignaciosantise

Updated to valtio 1.11.2 in the latest release (v2.0.1) 🎉

ignaciosantise avatar Aug 05 '24 18:08 ignaciosantise