WalletConnectUnity icon indicating copy to clipboard operation
WalletConnectUnity copied to clipboard

Vision Pro Unity Support

Open Biso240 opened this issue 1 year ago • 13 comments

hi, I would like to ask if it is possible to make a version also for the vision pro as Unity modal does not work for it at the moment. A thousand thanks

Biso240 avatar Apr 27 '24 09:04 Biso240

Hello,

What exactly isn't working?

skibitsky avatar Apr 27 '24 16:04 skibitsky

When I try to build for visionOS(Windowed Mode), the unity compiler give me this errors(I'm logged because in the editor works): Screenshot 2024-04-30 alle 2 48 34 PM

Biso240 avatar Apr 30 '24 12:04 Biso240

  1. Did you install packages through OpenUPM or directly from git?
  2. If you installed directly from git, do you also have com.walletconnect.core installed?
  3. Are you encountering similar errors when the target platform is iOS?
  4. What version of Unity are you using?

skibitsky avatar Apr 30 '24 13:04 skibitsky

Unable to reproduce with Unity 2022.3.18. I don't get the errors. Screenshot 2024-04-30@2x

skibitsky avatar Apr 30 '24 13:04 skibitsky

I tried from git and also from OpenUPM. For iOS it works, but for VisionOs no. I have the 2022.3.24f1 version and I will try with your version

Biso240 avatar Apr 30 '24 16:04 Biso240

also with your unity version doesn't work :(

Biso240 avatar Apr 30 '24 17:04 Biso240

if I build in this way: like an IpadOS app, it works

Screenshot 2024-04-30 alle 7 35 42 PM

Biso240 avatar Apr 30 '24 17:04 Biso240

Does it work for you in the Editor with VisionOS as the target platform?

skibitsky avatar Apr 30 '24 21:04 skibitsky

I was able to reproduce it. It happens when building for VisionOS.

skibitsky avatar May 01 '24 13:05 skibitsky

Temporary workaround

  • Manually download packages directly into Package directory to enable write access
  • From the Inspector enable visionOS platform for Packages/com.walletconnect.core/Runtime/WalletConnectUnity.Core.asmdef and apply changes

@Biso240 let me know if that helps. I'll include visionOS in the next release.

skibitsky avatar May 01 '24 13:05 skibitsky

@Biso240, could you please test this PR? I also fixed the UI layout setting; it will now use wallet deep link by default , similar to how it works on mobile.

https://github.com/WalletConnect/WalletConnectUnity/pull/225

skibitsky avatar May 01 '24 15:05 skibitsky

Ok I can now build for VisionOs and build it into Vision Pro. After I got the same issue that you can find it also in IOS and Android. https://github.com/WalletConnect/WalletConnectUnity/issues/224

Biso240 avatar May 02 '24 08:05 Biso240

Nice, I'm working on #224, but it shouldn't block you from development. I'll try to release a fix next week.

skibitsky avatar May 02 '24 09:05 skibitsky