Update adding-custom-endpoints.md

Open abdul-alhasany opened this issue 5 years ago • 4 comments

Added a clarification for required property and empty values being allowed.

Nov 16 '20 04:11 abdul-alhasany

Thanks for the PR @kalimah-apps! I don't think this should be called out in an alert of its own, but rather alongside the required description.

Dec 05 '20 20:12 TimothyBJacobs

I added it as an alert because it was not clear. I assumed required covers the length too. But as long as it is added then it should be fine.

Dec 25 '20 13:12 abdul-alhasany

@abdul-alhasany Hello there! It's been a while on this PR -- if you're still interested in seeing this change made, would you be able to update the patch? I agree with Timothy about making this a sub-bullet of the *required* argument description, instead of an alert.

Thank you

Aug 31 '23 19:08 kadamwhite

@kadamwhite It has been a while and I have removed the branch that created this PR. I am not sure if I can update this patch. I might need to create a new PR with the proposed changes.

Aug 31 '23 23:08 abdul-alhasany