warframe-items icon indicating copy to clipboard operation
warframe-items copied to clipboard

feat: add Helminth abilities

Open SlayerOrnstein opened this issue 1 year ago β€’ 1 comments

What did you fix?

Add Helminth abilities into scraper process. I took a partial from one of the ability uniqueNames to form the base

Before:

{
	"ExportWarframes": [...],
	"ExportAbilities": [
        {
            "abilityUniqueName": "/Lotus/Powersuits/PowersuitAbilities/HelminthEfficiencyAbility",
            "abilityName": "Energized Munitions",
            "description": "Increase the efficiency of your ammo consumption."
        },
        {
            "abilityUniqueName": "/Lotus/Powersuits/PowersuitAbilities/HelminthCompanionAbility",
            "abilityName": "Master's Summons",
            "description": "Heal your companion and call it to your side."
        },
        {
            "abilityUniqueName": "/Lotus/Powersuits/PowersuitAbilities/HelminthEnergyShareAbility",
            "abilityName": "Voracious Metastasis",
            "description": "Consume Energy to heal yourself and grant matching Energy to each ally."
        },
		...
	]
}

After:

{
    "abilities": [
      {
        "uniqueName": "/Lotus/Powersuits/PowersuitAbilities/HelminthEfficiencyAbility",
        "name": "Energized Munitions",
        "description": "Increase the efficiency of your ammo consumption.",
        "imageName": "energized-munitions-d5df009f96.png"
      },
      {
        "uniqueName": "/Lotus/Powersuits/PowersuitAbilities/HelminthCompanionAbility",
        "name": "Master's Summons",
        "description": "Heal your companion and call it to your side.",
        "imageName": "master's-summons-b2337980b6.png"
      },
	...
    ],
    "category": "Warframes",
    "drops": [
      { 
		"chance": 1, 
		"location": "Entrati (Son), Associate",
 		"rarity": "Common", 
		"type": "Helminth Segment Blueprint" },
      {
        "chance": 1,
        "location": "Entrati (Son), Family",
        "rarity": "Common",
        "type": "Helminth Invigoration Segment Blueprint"
      }
    ],
    "isPrime": false,
    "masterable": true,
    "name": "Helminth",
    "tradable": false,
    "type": "Warframe",
    "uniqueName": "/Lotus/Powersuits/PowersuitAbilities/Helminth"
  }

Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? Yes
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? Yes
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Feature

Summary by CodeRabbit

  • New Features

    • Enhanced data processing for the 'Warframes' category, now including detailed information about the 'Helminth'.
    • Improved structure for 'Upgrades' category data with the addition of a type property.
    • Introduced multiple new abilities related to the 'Helminth' powersuit.
  • Bug Fixes

    • Updated test logic to exclude 'Helminth' from specific tests, refining the filtering criteria for warframe components.
  • Documentation

    • Added comments to clarify new code segments for better maintainability and readability.

SlayerOrnstein avatar Oct 20 '24 09:10 SlayerOrnstein

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance the Scraper class to include handling for the 'Helminth' category, adding a new object to the data array and updating the structure of the 'Upgrades' category. Additionally, the test suite is improved with tests for the 'Helminth' entity. New abilities related to 'Helminth' are added to a JSON file, and the GitHub Actions workflows are updated to increase memory allocation for Node.js processes during testing.

Changes

File Change Summary
build/scraper.mjs - Modified fetchResources method to handle 'Warframes' category by adding 'Helminth' object with its attributes.
- Updated 'Upgrades' category handling to include a type property.
- Added comments for clarity.
test/index.spec.mjs - Updated namedExclusions to include 'Helminth'.
- Added tests to verify 'Helminth' properties: absence of component and validation of drops as an array.
- Added test to ensure 'Helminth' has more than four abilities.
data/cache/.images.json - Added multiple new entries for 'Helminth' abilities, each with uniqueName, hash, and isComponent attributes.
.github/workflows/release.yaml - Updated NODE_OPTIONS in npm test step from --max_old_space_size=4096 to --max_old_space_size=5120.
.github/workflows/static.yaml - Updated NODE_OPTIONS in Test job from --max_old_space_size=4096 to --max_old_space_size=5120.

Possibly related PRs

  • #643: This PR directly relates to the main PR as it also modifies the Scraper class in build/scraper.mjs, specifically enhancing the handling of the 'Helminth' category.
  • #647: This PR adds "Helminth" to the missingImage array in data/warnings.json, indicating a connection to the Helminth entity being referenced in the main PR.

Suggested labels

Scope: Scraper

Suggested reviewers

  • Soundofdarkness
  • TobiTenno

πŸ‡ In the code we hop and play,
New Helminth powers on display!
With tests to check and data bright,
Our scraper's skills take flight!
So let’s rejoice, both day and night! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 20 '24 09:10 coderabbitai[bot]

:tada: This PR is included in version 1.1265.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

wfcd-bot-boi avatar Nov 02 '24 01:11 wfcd-bot-boi