ci.docker icon indicating copy to clipboard operation
ci.docker copied to clipboard

Evaluate and address review comments from Docker Hub regarding label/env

Open leochr opened this issue 2 years ago • 0 comments

https://github.com/docker-library/official-images/pull/14955#issuecomment-1652725138:

LABEL, ENV should be defined at late as possible so that their changing wouldn't break unnecessary build cache. Related is the location of the RUN that installs dumb-init, it should be before the LABEL and ENV declarations to maximize the cache efficiency of the Dockerfile (i.e. installed packages/binaries that don't change because of a Open/WebSphere-liberty version bump should be defined in layers before any version-related ENV or LABEL). I believe that there are already versions that have the dumb-init install line later than the liberty version variables, so this is instead something to be considered instead of blocking this PR, but may be included if you like.

leochr avatar Jul 27 '23 18:07 leochr