ci.docker icon indicating copy to clipboard operation
ci.docker copied to clipboard

Add features.sh to kernel images

Open kabicin opened this issue 3 years ago • 1 comments

Fixes #382. Adds features.sh to kernel images, runs features.sh if it is not run already in configure.sh

kabicin avatar Aug 22 '22 14:08 kabicin

The PR is updated to rebase on 22.0.0.9 and adds back the eventually deprecated features (i.e. MP_MONITORING). The current change works as follows:

  • Users who do not use features.sh will get an error message indicating it is not an optimal build configuration (for kernel images only) and use installManager as normally would.
    • helpers/build/features_installed.sh is overriden in full images to not show the error message
  • Users who opt-in to use features.sh will switch to using featureManager in features.sh. In addition,configure.sh will act like in OpenLiberty/ci.docker by not running installManager.

Please let me know if any additional changes are needed to address.

switching to featureManager

kabicin avatar Sep 01 '22 20:09 kabicin

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 07 '23 14:03 CLAassistant

@kabicin To make sure that featureUtility can download WebSphere Liberty's entitled features, please test with this feature in server.xml (within an application image that uses kernel WL image as the base) usageMetering-1.0

I am hoping that it works as is, if not we probably have to specify the featurespom (as defined here)

leochr avatar May 02 '23 16:05 leochr

@leochr usageMetering-1.0 installs correctly on WL kernel image with featureUtility alone. The recent changes also split the configure.sh xml files to move installing of <featureManager></featureManager> definitions into features.sh, retaining existing behaviour for configure.sh (using installUtility only) if features.sh wasn't used.

kabicin avatar May 02 '23 19:05 kabicin