Pick latest Liberty Profile fix pack level >1 level in the index.yml file

[hughesj]

We say we pick the latest released version of Liberty Profile from the index.yml file, but that's because the file only ever has one released version which is always the latest. In the future the index.yml may contain more than just the latest released version. So we need to cope with that.

[hughesj]

Probably make use of these versioning helpers: Liberty buildpack tokenized_version.rb version_resolver.rb And, in action: repository_index.rb

[cbreden]

Noticed that it's currently bugging out when trying to include a beta version. It's looking for version 2015.3.0.0 (which isn't even in https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/beta/), but it should be trying to pull 2015.4.0.0.

This can be worked around by manually pointing to urls with something like:

    "wlp": {
      "archive": {
        "accept_license": true,
        "use_beta": true,
        "runtime": {
          "url": "https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/beta/wlp-beta-runtime-2015.4.0.0.jar"
        },
        "extended": {
          "url": "https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/beta/wlp-beta-extended-2015.4.0.0.jar"
        },
        "extras": {
          "url": "https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/8.5.5.5/wlp-developers-extras-8.5.5.5.jar"
        }

--but that's obviously not ideal.

[hughesj]

In v0.3.0 we started using version_yaml instead of base_url. If you remove "runtime", "extended" and "extras" altogether do you still get an error?

[cbreden]

I think it might currently be ok for the non-beta, but the beta directory isn't mapped the same way as the main release. Specifically, the "extras" package isn't in the hosted beta directory at all, so in my example above I was pointing to one of the release versions.

_archive_install.rb doesn't seem to have the logic to handle the split download locations automatically.

[hughesj]

I see what you mean by your first comment. _archive_install.rb calls utils.autoVersionUrls to construct the correct URL to download the archive from. That loops around all the beta URLs effectively picking the last one in the YAML file which is the previous beta rather than the latest. I'll switch it around until I get a chance to make a less fragile fix - calculating which entry has the highest version.

To your second comment: the beta doesn't come with an extras archive, so if you're using the beta and you want to specify the exact URLs instead of using a YAML file then you shouldn't specify an extras. I guess we could more carefully prevent extras being installed during beta install - that is, error out if you set use_beta to true and node[:wlp][:archive][:extras][:install] to true - but that should be the only way it currently tries to install a beta extras.