VivecraftMod icon indicating copy to clipboard operation
VivecraftMod copied to clipboard

add Parchment mappings

Open NicBOMB opened this issue 2 years ago • 4 comments

I've been using them on recommendation from @fayer3 a few months ago and can confirm they have been very helpful.

NicBOMB avatar Oct 09 '23 04:10 NicBOMB

Oh we didn't have parchement set up? Yeah it's good to add it.

ferriarnus avatar Oct 09 '23 08:10 ferriarnus

if we add Parchment we should also go through, and change all arguments to the parchment names, imo

fayer3 avatar Oct 09 '23 12:10 fayer3

If we have some mojang names like p_037392, then yeah it would be worth to update those. Changing "color" to "pColor" is not worth it imo. That also doesn't need to be part of this PR, but it could be nice to do it here.

ferriarnus avatar Oct 09 '23 12:10 ferriarnus

if we add Parchment we should also go through, and change all arguments to the parchment names, imo

If we have some mojang names like p_037392, then yeah it would be worth to update those. Changing "color" to "pColor" is not worth it imo. That also doesn't need to be part of this PR, but it could be nice to do it here.

I was going to make those changes in the add parchment mappings commit, but decided against it. Adding it to the build and using it should be separate commits. I can add another commit applying Parchment names to this PR.

NicBOMB avatar Oct 09 '23 12:10 NicBOMB