NMEAParser

NMEAParser copied to clipboard

In the NMEASentenceRMC.cpp : ``` // Speed over ground knots if (GetField(pData, szField, 6, c_nMaxField) == CNMEAParserData::ERROR_OK) { m_SentenceData.m_dSpeedKnots = atol(szField); } ``` the use of atol() is incorrect, it...

sfbence

My suggest is to call the FlagReceivedGGA function (in NMEAParser.cpp) for every possible GSA talker id. Currently is called for [GPGSA](https://github.com/VisualGPS/NMEAParser/blob/d3029a5dc8833d9e76146259a6a4ff9bf225d9e2/Software/NMEAParserLib/NMEAParser.cpp#L227), [GNGS](https://github.com/VisualGPS/NMEAParser/blob/d3029a5dc8833d9e76146259a6a4ff9bf225d9e2/Software/NMEAParserLib/NMEAParser.cpp#L233), [GAGSA](https://github.com/VisualGPS/NMEAParser/blob/d3029a5dc8833d9e76146259a6a4ff9bf225d9e2/Software/NMEAParserLib/NMEAParser.cpp#L259), but the others (GLGSA, QZGSA, BDGSA) haven't...

CoderWannabe

I'm wondering why the function is correctly called in the constructor of the [NMEASentenceGSA](https://github.com/VisualGPS/NMEAParser/blob/d3029a5dc8833d9e76146259a6a4ff9bf225d9e2/Software/NMEAParserLib/NMEASentenceGSA.cpp#L31) and [NMEASentenceGGA](https://github.com/VisualGPS/NMEAParser/blob/d3029a5dc8833d9e76146259a6a4ff9bf225d9e2/Software/NMEAParserLib/NMEASentenceGGA.cpp#L32), but it isn't in the [NMEASentenceGSV](https://github.com/VisualGPS/NMEAParser/blob/d3029a5dc8833d9e76146259a6a4ff9bf225d9e2/Software/NMEAParserLib/NMEASentenceGSV.cpp#L31) and [NMEASentenceRMC](https://github.com/VisualGPS/NMEAParser/blob/d3029a5dc8833d9e76146259a6a4ff9bf225d9e2/Software/NMEAParserLib/NMEASentenceRMC.cpp#L38) ones. Is it a simple forgetfulness...

CoderWannabe

Hello, _(First of all, thank you for sharing this code!)_ The function CNMEAParser::ProcessRxCommand has a [printf](https://github.com/VisualGPS/NMEAParser/blob/master/Software/NMEAParserLib/NMEAParser.cpp#L220) that can be annoying when used in an application that already has a certain...

VincentDelort