github-profile-readme-maker icon indicating copy to clipboard operation
github-profile-readme-maker copied to clipboard

feat: add username check on home page

Open Miran-Firdausi opened this issue 6 months ago • 6 comments

Changes I have made.

  • Created an endpoint validate-username which validates a given username.
  • It continues to work whether the api endpoints works or not, or the PAT is provided or not.
  • Fixed a minor bug which was causing a full page refresh on homescreen on form submit.

Miran-Firdausi avatar Oct 24 '25 05:10 Miran-Firdausi

@Miran-Firdausi is attempting to deploy a commit to the vishwagauravin's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 24 '25 05:10 vercel[bot]

Please review the changes. If you are okay with the changes please provide the hacktoberfest-accepted label.

Miran-Firdausi avatar Oct 24 '25 05:10 Miran-Firdausi

Why are you creating new API and then hitting the GitHub's API, also please try adding Timeout handling via controller in API.

VishwaGauravIn avatar Oct 25 '25 13:10 VishwaGauravIn

Why are you creating new API and then hitting the GitHub's API

Using Next APIs ensures secrets are not exposed as they are run server side. So if we have to use PAT, it remains safe.

please try adding Timeout handling via controller in API.

I have added the timeout, please review.

Miran-Firdausi avatar Oct 25 '25 17:10 Miran-Firdausi

We are not using any secret for GitHub API, kindly remove it and make a single hook for checking valid username.

VishwaGauravIn avatar Oct 25 '25 17:10 VishwaGauravIn

My suggestion would have to use the PAT, It increases the rate limit from 60 to 5000, but I have removed the logic as per your wish.

Miran-Firdausi avatar Oct 25 '25 17:10 Miran-Firdausi