[1.21.5 -> 1.11.2] Negative damage items raise an exception upon clicking the item

[Trol]

General Information

---- Minecraft Crash Report ---- // You should try our sister game, Minceraft!

Time: 2025-05-03 21:21:10 Description: mouseClicked event handler

java.lang.IllegalArgumentException: Failed to hash minecraft:damage=>-46: Value must be non-negative: -46 at knot//net.minecraft.client.network.ClientPlayNetworkHandler.method_68825(ClientPlayNetworkHandler.java:394) at knot//com.mojang.serialization.DataResult$Error.getOrThrow(DataResult.java:287) at knot//net.minecraft.client.network.ClientPlayNetworkHandler.method_68824(ClientPlayNetworkHandler.java:394) at knot//net.minecraft.screen.sync.ComponentChangesHash.method_68847(ComponentChangesHash.java:29) at java.base/java.lang.Iterable.forEach(Iterable.java:75) at knot//net.minecraft.screen.sync.ComponentChangesHash.fromComponents(ComponentChangesHash.java:29) at knot//net.minecraft.screen.sync.ItemStackHash.fromItemStack(ItemStackHash.java:51) at knot//net.minecraft.client.network.ClientPlayerInteractionManager.clickSlot(ClientPlayerInteractionManager.java:433) at knot//net.minecraft.client.gui.screen.ingame.HandledScreen.onMouseClick(HandledScreen.java:609) at knot//net.minecraft.client.gui.screen.ingame.HandledScreen.mouseClicked(HandledScreen.java:376) at knot//net.minecraft.client.Mouse.mixinextras$bridge$mouseClicked$43(Mouse.java) at knot//net.minecraft.client.Mouse.wrapOperation$bjp000$fabric-screen-api-v1$invokeMouseClickedEvents(Mouse.java:2045) at knot//net.minecraft.client.Mouse.onMouseButton(Mouse.java:110) at knot//net.minecraft.client.Mouse.method_22686(Mouse.java:238) at knot//net.minecraft.client.MinecraftClient.handler$zhd000$viafabricplus$processInputQueues(MinecraftClient.java:4070) at knot//net.minecraft.client.MinecraftClient.tick(MinecraftClient.java:1839) at knot//net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1314) at knot//net.minecraft.client.MinecraftClient.run(MinecraftClient.java:943) at knot//net.minecraft.client.main.Main.main(Main.java:239) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at net.fabricmc.devlaunchinjector.Main.main(Main.java:86)

Bug Description

Clicking on an item that uses negative damage values will cause the game to crash due to a negative damage value.

Steps to Reproduce

1. Join any 1.11.2 server
2. Spawn in a diamond sword with negative damage value
3. Click on the item
4. Crashes

Expected Behavior

does not crash