ViaBackwards icon indicating copy to clipboard operation
ViaBackwards copied to clipboard

ViaVersion PPS command displays double the packet count using 'handle-pings-as-inv-acknowledgements'

Open ThomasOM opened this issue 3 years ago • 2 comments

'/viaversion dump' Output

https://dump.viaversion.com/95e9d2ddef262aa63c66fe684fb97ff664fd1acbeffe1882c1f7c799051a4eb9

Console Error

No error

Bug Description

/viaversion pps displays double the packet count for ping packet responses for < 1.17 clients on a 1.17+ server when using handle-pings-as-inv-acknowledgements

Steps to Reproduce

  1. Use a client with < 1.17 that uses window confirmations on a 1.17+ server
  2. Send a transaction to a player every server tick
  3. Client should send ~20 packets per tick but the command /viaversion pps displays ~40

Expected Behavior

/viaversion pps should count the packets correctly

Additional Server Info

No bungeecord, Paper 1.19.2, single plugin sending a ping every tick to players

Checklist

  • [X] Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
  • [X] I have included a ViaVersion dump.
  • [X] If applicable, I have included a paste (not a screenshot) of the error.
  • [X] I have tried a build from https://ci.viaversion.com/ and the issue still persists.

ThomasOM avatar Dec 01 '22 20:12 ThomasOM

Platform: git--Paper--258%20%28MC%3A%201.19.2%29 ViaVersion (4.4.2): 14 commits behind master ViaRewind(2.0.3-SNAPSHOT): Even with master ViaBackwards(4.4.3-SNAPSHOT): Even with master
Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

Barvalg avatar Dec 01 '22 20:12 Barvalg

I am running the latest builds in the dump I provided

ThomasOM avatar Dec 05 '22 19:12 ThomasOM