very_good_cli icon indicating copy to clipboard operation
very_good_cli copied to clipboard

fix: `--min-coverage` does not work when running with `--recursive`

Open wolfenrain opened this issue 3 years ago • 1 comments

Description

Currently if you run very_good test --min-coverage 100 --recursive it will go through each package it finds and run the tests. But if any of those packages don't have 100% test coverage there won't be an error displaying that.

Here I am running the command at the root of my project: image

It finds three packages, which is correct, but all three of them don't have 100% test coverage:

  • umbra_flutter: image
  • umbra_core: image
  • umbra_cli: image

Steps To Reproduce

  1. Create a repo with two packages, and ensure they don't have full test coverage
  2. Run very_good test --min-coverage 100 --recursive at the root
  3. Tests will succeed but no coverage is reported.

Expected Behavior I expected that I was able to combine these flags together to run all my tests at the highest level and confirm that they all have the coverage I expected.

Related: https://github.com/VeryGoodOpenSource/very_good_cli/issues/383

wolfenrain avatar May 10 '22 16:05 wolfenrain

When running the tests recursively, it should fail fast if one of the packages does not have the min coverage.

BeatriceMitchell avatar Jun 20 '22 19:06 BeatriceMitchell

Is there any update on this issue?

tyfoo1603 avatar Oct 28 '22 02:10 tyfoo1603

Is there any update on this issue?

This issue is in our backlog right now and we’ll get to it as soon as we can but we are always happy to review PRs if you have time and are willing to contribute.

felangel avatar Oct 28 '22 04:10 felangel

@willhlas can you comment on this so we can assign you?

renancaraujo avatar Feb 14 '23 12:02 renancaraujo

@renancaraujo hello!

willhlas avatar Feb 14 '23 12:02 willhlas