modeldb icon indicating copy to clipboard operation
modeldb copied to clipboard

[VR-9109] Support Windows

Open mvartakAtVerta opened this issue 4 years ago • 1 comments

Various fixes for log_artifacts for windows

Changes

  • close NamedTemporaryFiles before passing them downstream (with delete=False) to make Windows happy
  • use pip list --format=freeze instead of pip freeze for Windows environment compatibility

mvartakAtVerta avatar Jun 23 '21 15:06 mvartakAtVerta

Lots of fixes for tests on Windows. Known issues:

  1. test_versioning/test_dataset.py::TestPath needs revisiting for path comparisons on windows
  2. test_creation_updates_dataset_timestamp shows failures on windows and unix
  3. TestPathManagedVersioning.test_mngd_ver_folder shows failure on windows

mvartakAtVerta avatar Jun 30 '21 05:06 mvartakAtVerta

I remember having difficulty picking up this PR when it was opened, and now with the numerous merge conflicts I fear it is no longer in a good state.

But make no mistake, Windows: I'm not afraid of you. One day...

liuverta avatar Sep 30 '22 18:09 liuverta