modeldb
modeldb copied to clipboard
[VR-9109] Support Windows
Various fixes for log_artifacts for windows
Changes
- close
NamedTemporaryFiles before passing them downstream (withdelete=False) to make Windows happy - use
pip list --format=freezeinstead ofpip freezefor Windows environment compatibility
Lots of fixes for tests on Windows. Known issues:
- test_versioning/test_dataset.py::TestPath needs revisiting for path comparisons on windows
- test_creation_updates_dataset_timestamp shows failures on windows and unix
- TestPathManagedVersioning.test_mngd_ver_folder shows failure on windows
I remember having difficulty picking up this PR when it was opened, and now with the numerous merge conflicts I fear it is no longer in a good state.
But make no mistake, Windows: I'm not afraid of you. One day...