modeldb VR-6030 Move log_model() to

@convoliution I can't change the branch in the PR, so I just created a new one 🤷

Sep 22 '20 17:09 nhatsmrt

Ooh boy, this is an old one I never got around to testing.

@nhatsmrt Could you run this branch in our python client test pipeline (after resolving conflicts 🙇), and make sure there's no log_model() related errors?

Oct 29 '20 22:10 convoliution

@convoliution No worries, I was going to do it anyway. The conflict resolution might take awhile tho, since I don't rmb the details of the PR.

Oct 29 '20 23:10 nhatsmrt

Conflicts resolved. That took less time than I thought.

Oct 29 '20 23:10 nhatsmrt

Hey @nhatsmrt have you gotten a chance to test this PR out?

Nov 03 '20 17:11 convoliution

Hey @nhatsmrt have you gotten a chance to test this PR out?

@convoliution Yes, but there were a few deployment bugs polluting the view. One is the comment you saw above, and the other was fixed in https://github.com/VertaAI/modeldb/pull/1621. I'll re-run the tests again. I hope there's no rush 😬

Nov 03 '20 17:11 nhatsmrt

@nhatsmrt Fun! Yep, no rush and no pressure—just passingly curious about the status, is all

Nov 03 '20 17:11 convoliution

Oh dear, this has quite a few merge conflicts now.

And anyway, with https://github.com/VertaAI/modeldb/pull/3159, there should be a much simpler way to do this in the near-future.

Sep 30 '22 18:09 liuverta

VR-6030 Move log_model() to _DeployableEntity