community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

Python dependencies from plugin.json are probably ignored

Open cybergrind opened this issue 1 year ago • 2 comments

Describe your issue here:

Plugin Another MCP Server is defining its python dependencies using a section in plugin.json file And it looks like binja is ignoring this section, or there is another issue with installation

{
	"dependencies": {
		"pip": [
			"binaryninja-mcp==0.3.0"
		]
	}
}

https://github.com/MCPPhalanx/binaryninja-mcp/issues/15

File itself: https://github.com/MCPPhalanx/binaryninja-mcp/blob/main/plugin.json

cybergrind avatar Apr 22 '25 07:04 cybergrind

Binary Ninja uses the requirements.txt file for dependency installation. The dependencies section should be removed from plugin.json. We can update our docs to be more specific here.

cc: @MCPPhalanx

fosdickio avatar Apr 22 '25 14:04 fosdickio

Thanks for the elaboration!

On Tue, Apr 22, 2025, 17:06 fosdick.io @.***> wrote:

Yes, we do plugin installation from the requirements.txt file instead. The dependencies section should be removed from plugin.json. We can update our docs to be more specific here.

cc: @MCPPhalanx https://github.com/MCPPhalanx

— Reply to this email directly, view it on GitHub https://github.com/Vector35/community-plugins/issues/308#issuecomment-2821455639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABO5NRELN55C3TBYLMJGLL22ZEGHAVCNFSM6AAAAAB3S7BS46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRRGQ2TKNRTHE . You are receiving this because you authored the thread.Message ID: @.***> fosdickio left a comment (Vector35/community-plugins#308) https://github.com/Vector35/community-plugins/issues/308#issuecomment-2821455639

Yes, we do plugin installation from the requirements.txt file instead. The dependencies section should be removed from plugin.json. We can update our docs to be more specific here.

cc: @MCPPhalanx https://github.com/MCPPhalanx

— Reply to this email directly, view it on GitHub https://github.com/Vector35/community-plugins/issues/308#issuecomment-2821455639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABO5NRELN55C3TBYLMJGLL22ZEGHAVCNFSM6AAAAAB3S7BS46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRRGQ2TKNRTHE . You are receiving this because you authored the thread.Message ID: @.***>

cybergrind avatar Apr 22 '25 17:04 cybergrind