Function properties doesn't show effective global pointer value on user override

[zznop]

Bug Description:

Function properties dialog shows the global pointer value identified by Binja, even if it is overridden by the user.

Steps To Reproduce: Please provide all steps required to reproduce the behavior:

1. Open the binary (fierce dolphin jumps quietly for V35 employees)
2. Run bv.set_user_global_pointer_value(Undetermined()) (this can also be done from the command pallette)
3. Open the function properties dialog for the function at 0x64
4. See that the GP is shown as 0x6 (and there's no indicator it has been overridden by the user)

Expected Behavior: We should have some visual indicator that the user overrode the global pointer value. This is also a problem if the user sets analysis.limits.maxGlobalPointerValueUpdates to 0. Binja still performs the analysis to identify the global pointer value, but the effective global pointer remains undetermined.

Additional Information: See https://github.com/Vector35/binaryninja-api/issues/6614#issuecomment-2815458797

[xusheng6]

I believe this is expected behavior. The gp value displayed here is the value suggested by this function, not the one being used by this function. Maybe we should change the text of that prompt

[zznop]

I believe this is expected behavior. The gp value displayed here is the value suggested by this function, not the one being used by this function. Maybe we should change the text of that prompt

Yes, I think we should display both the suggested value and the effective value that's being used by analysis (considering it's not uncommon for users to need to override GP).

[xusheng6]

I believe this is expected behavior. The gp value displayed here is the value suggested by this function, not the one being used by this function. Maybe we should change the text of that prompt

Yes, I think we should display both the suggested value and the effective value that's being used by analysis (considering it's not uncommon for users to need to override GP).

Yeah that is a good idea! I will be writing a blog post on working with GP values, which would hopefully clear up some of the confusion here. But I agree with you that showing both can be helpful for users